-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow users to enter partial/complete channel to fetch conversation #782
base: main
Are you sure you want to change the base?
feat: allow users to enter partial/complete channel to fetch conversation #782
Conversation
…tion. Updated the tasks.json file. Allowing slack to read multiple channel-names by changing type from (string-->array). For example: typing 'dev' retrieves conversations from all channels containing 'dev'."
Hey @chuang8511 |
Hi @VibhorGits , |
Hey @chuang8511 do I need to implement the execution logic from scratch or make the changes only for reading messages in the file say main.go file or tasks_function.go (as per my understanding). |
You need to modify this function. Now, the |
@chuang8511 What about changing the task_function.go file |
Yes, that is mainly what I mean! |
Hey @chuang8511 I have made the necessary changes. Should I open another pr? |
Hey @chuang8511 I made changes in another branch and opened a separate pr. |
Please put them in the same PR and do the testing including:
|
@chuang8511 I dont know how to put them into same pr |
Hey @chuang8511 I tried running the backend on my mac but couldn't run due to hardware specs. |
Updated the tasks.json file.
Allowing slack to read multiple channel-names by changing type from (string-->array).
For example:
typing 'dev' retrieves conversations from all channels containing 'dev'."
Because
By implementing this functionality users can fetch by partial/complete typing.
Fixes Issue #1110
instill-ai/instill-core#1110
This commit
Code changes in pkg/component/application/slack/v0/config/tasks.json
Changed datatype of Channel-names in "TASK_READ_MESSAGE"
from string --> array.