Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to enter partial/complete channel to fetch conversation #782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VibhorGits
Copy link

@VibhorGits VibhorGits commented Oct 25, 2024

Updated the tasks.json file.
Allowing slack to read multiple channel-names by changing type from (string-->array).
For example:
typing 'dev' retrieves conversations from all channels containing 'dev'."

Because

  • Currently users need to type the entire channel name to fetch conversation.
    By implementing this functionality users can fetch by partial/complete typing.

Fixes Issue #1110
instill-ai/instill-core#1110

This commit

Code changes in pkg/component/application/slack/v0/config/tasks.json

Changed datatype of Channel-names in "TASK_READ_MESSAGE"
from string --> array.

…tion.

Updated the tasks.json file.
Allowing slack to read multiple channel-names by changing 
type from (string-->array).
For example:
typing 'dev' retrieves conversations from all channels containing 'dev'."
@VibhorGits
Copy link
Author

Hey @chuang8511
Checkout my changes and let me know if some further work is required.

@chuang8511
Copy link
Member

Hi @VibhorGits ,
you missed this part. Could you implement it?

@VibhorGits
Copy link
Author

VibhorGits commented Oct 29, 2024

Hey @chuang8511 do I need to implement the execution logic from scratch or make the changes only for reading messages in the file say main.go file or tasks_function.go (as per my understanding).

@chuang8511
Copy link
Member

chuang8511 commented Oct 29, 2024

You need to modify this function.

Now, the readMessage only reads a channel. Now, we want it to be able to read channels.

@VibhorGits
Copy link
Author

VibhorGits commented Oct 29, 2024

@chuang8511 What about changing the task_function.go file
I think we need to change there as well?

@chuang8511
Copy link
Member

What about changing the task_function.go file. I think we need to change there as well?

Yes, that is mainly what I mean!

@VibhorGits
Copy link
Author

Hey @chuang8511 I have made the necessary changes. Should I open another pr?

@VibhorGits
Copy link
Author

Hey @chuang8511 I made changes in another branch and opened a separate pr.
Here are the changes in the pr: #788

@chuang8511
Copy link
Member

Please put them in the same PR and do the testing including:

  • unit test
  • end-to-end test

@VibhorGits
Copy link
Author

@chuang8511 I dont know how to put them into same pr

@VibhorGits
Copy link
Author

VibhorGits commented Oct 29, 2024

Hey @chuang8511 I tried running the backend on my mac but couldn't run due to hardware specs.
Here's the thread: https://discord.com/channels/928991293856681984/1298346473561526273
I dont think I will be able to perform the testing locally on my pc.
Regarding the pr process may I ask you to review it for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants