Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metric): model trigger chart records api #500

Merged
merged 2 commits into from
Oct 29, 2024
Merged

feat(metric): model trigger chart records api #500

merged 2 commits into from
Oct 29, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 28, 2024 •
edited
Loading

Because

  • dashboard needs API for model trigger count

This commit

  • add new metrics API

@linear Linear
Copy link

linear bot commented Oct 28, 2024

INS-6717 model trigger counts api

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 29, 2024, 2:51 AM

@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-counts-api branch 3 times, most recently from 68d0dc9 to 3bdc95e Compare October 28, 2024 06:59
@joremysh joremysh changed the title feat(metric): model trigger count metrics api feat(metric): model trigger chart records api Oct 28, 2024
@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-counts-api branch 2 times, most recently from 53eb402 to 920a817 Compare October 28, 2024 10:13
jvallesm
jvallesm reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following the proposed design in #435. I added a couple of comments but it seems in the good track.

core/mgmt/v1beta/mgmt_public_service.proto Outdated Show resolved Hide resolved
core/mgmt/v1beta/mgmt_public_service.proto Outdated Show resolved Hide resolved
openapiv2/core/service.swagger.yaml Outdated Show resolved Hide resolved
@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-counts-api branch from 38e1285 to c7a5a86 Compare October 29, 2024 02:50
@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-counts-api branch from c7a5a86 to 22057cd Compare October 29, 2024 02:51
@donch1989 donch1989 merged commit d8a26e2 into main Oct 29, 2024
@donch1989 donch1989 deleted the jeremy/ins-6717-model-trigger-counts-api branch October 29, 2024 09:05
@droplet-bot droplet-bot mentioned this pull request Oct 29, 2024
Open
@jvallesm jvallesm mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm jvallesm approved these changes

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joremysh @donch1989 @jvallesm @droplet-bot