Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vdp): refactor trigger endpoints #506

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

donch1989
Copy link
Member

Because

  • Previously, we used structpb for our trigger endpoints, which supports JSON but isn’t suitable for binary data.

This commit:

  • Refactors the trigger endpoints, separating those that use structpb (which doesn’t support binary data) from those using our custom message for binary data.
  • Introduces a gRPC streaming trigger endpoint.
  • Reorganizes message structures.

Copy link

github-actions bot commented Nov 3, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 4, 2024, 2:58 AM

Comment on lines +7 to +8
// JsonValue represents a JSON value.
message JsonValue {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// JsonValue represents a JSON value.
message JsonValue {
// JSONValue represents a JSON value.
message JSONValue {

I think we should follow this guide for initialisms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants