Skip to content

Commit

Permalink
fix(client): added some parameter default values for artifact (#192)
Browse files Browse the repository at this point in the history
Because

- page size and page token default values for artifact should align with
those in pipeline and model

This commit

- added default values for list params
  • Loading branch information
joremysh authored Jul 31, 2024
1 parent dd5cfa7 commit ab624f4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions docs/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
mkdocs==1.3.1 ; python_version >= "3.8" and python_version < "3.13"
pygments==2.17.2 ; python_version >= "3.8" and python_version < "3.13"
jinja2==3.1.4 ; python_version >= "3.8" and python_version < "3.13"
mkdocs==1.3.1 ; python_version >= "3.9" and python_version < "3.12"
pygments==2.17.2 ; python_version >= "3.9" and python_version < "3.12"
jinja2==3.1.4 ; python_version >= "3.9" and python_version < "3.12"
8 changes: 4 additions & 4 deletions instill/clients/artifact.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,9 @@ def list_knowledge_base_files(
self,
namespace_id: str,
kb_id: str,
page_size: int,
page_token: str,
files_filter: artifact_interface.ListKnowledgeBaseFilesFilter,
page_size: int = 100,
page_token: str = "",
async_enabled: bool = False,
) -> artifact_interface.ListKnowledgeBaseFilesResponse:
if async_enabled:
Expand All @@ -306,9 +306,9 @@ def list_knowledge_base_files(
request=artifact_interface.ListKnowledgeBaseFilesRequest(
namespace_id=namespace_id,
kb_id=kb_id,
filter=files_filter,
page_size=page_size,
page_token=page_token,
filter=files_filter,
),
metadata=self.hosts[self.instance].metadata,
).send_async()
Expand All @@ -318,9 +318,9 @@ def list_knowledge_base_files(
request=artifact_interface.ListKnowledgeBaseFilesRequest(
namespace_id=namespace_id,
kb_id=kb_id,
filter=files_filter,
page_size=page_size,
page_token=page_token,
filter=files_filter,
),
metadata=self.hosts[self.instance].metadata,
).send_sync()
Expand Down

0 comments on commit ab624f4

Please sign in to comment.