fix definition interpreter

instride-ch · May 27, 2024 · 4456ab7 · 4456ab7
1 parent b25348a
commit 4456ab7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -69,4 +69,6 @@ web
 public
 docker-compose.yaml
 test-commands.txt
-.docker
+.docker
+cache
+config/pimcore/data-definitions
diff --git a/src/DataDefinitionsBundle/Interpreter/DefinitionInterpreter.php b/src/DataDefinitionsBundle/Interpreter/DefinitionInterpreter.php
@@ -34,7 +34,7 @@ public function __construct(RepositoryInterface $definitionRepository, ImporterI
     }
 
     public function interpret(InterpreterContextInterface $context): mixed {
-        $subDefinition = $this->definitionRepository->find((string)($context->getConfiguration()['definition']));
+        $subDefinition = $this->definitionRepository->find($context->getConfiguration()['definition']);
 
         if (!$subDefinition instanceof ImportDefinitionInterface) {
             return null;

diff --git a/src/DataDefinitionsBundle/Model/ExportDefinition.php b/src/DataDefinitionsBundle/Model/ExportDefinition.php
@@ -36,7 +36,7 @@ class ExportDefinition extends AbstractDataDefinition implements ExportDefinitio
      */
     public $fetchUnpublished = false;
 
-    public static function getById(string $name)
+    public static function getById(int $name)
     {
         return static::getByName($name);
     }

diff --git a/src/DataDefinitionsBundle/Model/ImportDefinition.php b/src/DataDefinitionsBundle/Model/ImportDefinition.php
@@ -86,7 +86,7 @@ class ImportDefinition extends AbstractDataDefinition implements ImportDefinitio
      */
     public $persister;
 
-    public static function getById(string $name)
+    public static function getById(int $name)
     {
         return static::getByName($name);
     }