Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23: Global setup for Playwright, and some basic Playwright UI tests #254

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

adigidh
Copy link

@adigidh adigidh commented Oct 8, 2024

fixes #23

Summary of changes:

  • Setup Playwright (installed packages, setup configuration)
  • Created a simple setup test that performs a real login with an e2e account and saves the storage state so the next tests can run in an authenticated state. Using env variables for username, and password so these can be supplied from the user.
  • Basic tests for login page
  • NPM scripts for execution on local
  • Docs in development markdown for running these tests locally

Example report after running the tests locally:
image

@vishnoianil
Copy link
Member

@adigidh Exited to see this PR. Thanks for pushing this. Let me know if this PR is ready for review.
Didn't look at it yet because it's in draft, so I am assuming it's still work in progress.

@adigidh
Copy link
Author

adigidh commented Oct 21, 2024

@adigidh Exited to see this PR. Thanks for pushing this. Let me know if this PR is ready for review. Didn't look at it yet because it's in draft, so I am assuming it's still work in progress.

@vishnoianil : Sent you a DM last week. Maybe this PR is good for first pass?
I'll resolve the conflicts on this one, and open it up for review.

@vishnoianil
Copy link
Member

@adigidh Exited to see this PR. Thanks for pushing this. Let me know if this PR is ready for review. Didn't look at it yet because it's in draft, so I am assuming it's still work in progress.

@vishnoianil : Sent you a DM last week. Maybe this PR is good for first pass? I'll resolve the conflicts on this one, and open it up for review.

@adigidh PR looks good to me. Can you please add instructions for running the test cases in the development doc in docs directory. Once you update the docs, PR it good for merge, so please mark it ready for review.

@adigidh adigidh marked this pull request as ready for review October 22, 2024 13:11
@adigidh
Copy link
Author

adigidh commented Oct 22, 2024

re: #254 (comment)

Thanks for the feedback @vishnoianil. Made some updates, and opened it up for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some basic Playwright UI tests
2 participants