Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement call quality estimation (#27) #132

Merged
merged 66 commits into from
Sep 1, 2020
Merged

Implement call quality estimation (#27) #132

merged 66 commits into from
Sep 1, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Aug 27, 2020 •
edited
Loading

Part of #27

Synopsis

We need to measure call quality and provide information about current score to the JS side.

Solution

Quality score will be calculated based on Algorithm::MOS, which is derived from E-model, introduced in ITU-T G.107 with some simplifications and tweaks.

  • Store RTC stats within some period at the server and periodically calculate and send quality score to the Jason
  • Add Room.on_quality_score_update callback to the Jason into which call quality updates will be provided

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

evdokimovs and others added 30 commits July 28, 2020 19:57
@evdokimovs
Add force tracks updating
96baa50
@evdokimovs
Add docs
828407a
@evdokimovs
Fix some mute/unmute case
d73a57a
@evdokimovs
Add test [run ci]
ec7b848
@evdokimovs
Refactor [run ci]
83d8573
@evdokimovs
Add recv Tracks muting
3cfb49c
@alexlapa
Merge branch 'master' into tracks-disabling-optimization
f8cd0fb
@alexlapa
cargo update
b747a17
@evdokimovs
Add more tests [run ci]
7bd125c
@evdokimovs
Maybe fix E2E test [run ci]
a58f8c1
@evdokimovs
Fix remote unmuting on new Member connecting
92680a8
@evdokimovs
Update e2e-demo
4461fee
@evdokimovs
Merge branch 'master' into senders-muting-by-subsciber
d412df7
@evdokimovs
Reread [run ci]
b324dc2
@evdokimovs
Add CHANGELOG entry
c09f77e
@evdokimovs
Make clippy happy [run ci]
8db6bd3
@evdokimovs
Maybe fix E2E test [run ci]
ba4a94c
@evdokimovs
Debug E2E [run ci]
a544a2b
@evdokimovs
Debug [run ci]
f444ab5
@evdokimovs
E2E tests should be fixed [run ci]
d17d504
@evdokimovs
[run ci]
1fb97a9
@evdokimovs
[run ci]
a17565d
@evdokimovs
Add connection meter
3fcc618
@evdokimovs
[run ci]
cec14e7
@evdokimovs
[run ci]
acc6e40
@evdokimovs
Merge branch 'master' into tracks-disabling-optimization [run ci]
cc5ef6a
@evdokimovs
Fix formatting
a4d399b
@evdokimovs
Add more docs for peer module
913919b
@alexlapa
corrections, cargo update
78362d3
@evdokimovs
Add connection meter indicator
3cc5ac0
alexlapa and others added 7 commits August 17, 2020 11:47
@alexlapa
Merge branch 'master' into poor-connection-demo
eacce32 
# Conflicts:
#	Cargo.lock
#	src/media/peer.rs
#	src/signalling/peers/mod.rs
#	src/signalling/room/command_handler.rs
#	src/signalling/room/peer_events_handler.rs
#	tests/e2e/signalling/track_disable.rs
@alexlapa
merge
4f14416
@alexlapa
refactor
e17ca68
@evdokimovs
Merge branch 'master' into poor-connection-demo
8931df1
@evdokimovs
Merge branch 'poor-connection-demo' of github.com:instrumentisto/mede…
9179028 
…a into poor-connection-demo
@evdokimovs
Reread
517bae5
@evdokimovs
Update RFC and CHANGELOGs [run ci]
d647c5c
@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::monitoring Related to monitoring capabilities labels Aug 27, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Aug 27, 2020
@evdokimovs evdokimovs self-assigned this Aug 27, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Aug 27, 2020 •
edited by tyranron
Loading

FCM

Implement call quality estimation (#132, #27)

- calculate connection quality based on client RTC stats
- add 'ConnectionHandle.on_quality_score_update' callback to Jason

@evdokimovs evdokimovs changed the title Draft: Implement call quality measurement (#27) Implement call quality measurement (#27) Aug 27, 2020
@evdokimovs evdokimovs marked this pull request as ready for review August 27, 2020 13:41
@evdokimovs evdokimovs requested a review from alexlapa August 27, 2020 13:42
@alexlapa alexlapa changed the title Implement call quality measurement (#27) Implement call quality estimation (#27) Aug 31, 2020
@alexlapa alexlapa requested a review from tyranron August 31, 2020 15:51
@tyranron tyranron added the k::design Related to overall design and/or architecture label Sep 1, 2020
tyranron
tyranron approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that code quality somehow became worse.

@evdokimovs be more patient to the code/docs quality you're writing. Don't be lazy to make them consistent, rich and understantable even for beginners.

src/signalling/peers/metrics.rs Outdated
{
break (peer_id, was_flowing_at, media_type, direction);
} else {
continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if a == b { return true; } else { return false; }

src/signalling/room/command_handler.rs Outdated
///
/// Passes [`PeerMetrics::RtcStats`] to [`PeersService`] for further
/// analysis.
#[allow(clippy::single_match)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not if let then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyranron ,

В будущем эта функция должна будет делать матч по всем вариантам, поэтому решил заранее это показать.

@evdokimovs evdokimovs merged commit d75eba1 into master Sep 1, 2020
@evdokimovs evdokimovs deleted the poor-connection-demo branch September 1, 2020 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture k::monitoring Related to monitoring capabilities
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa