Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Fix RpcClient reference leak in Jason (#27) #140

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Sep 16, 2020

Part of #27

Synopsis

After RpcClientwas refactored to async_trait usage in #135, RpcClient::on_normal_close starts require one more reference to the RpcClient. Because of it, RpcClient remains alive after Room close.

Solution

  1. Return LocalBoxFuture from the RpcClient::on_normal_close instead of async fn usage

  2. Add unit tests for this bug

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added bug Something isn't working enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Sep 16, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Sep 16, 2020
@evdokimovs evdokimovs self-assigned this Sep 16, 2020
@evdokimovs
Copy link
Contributor Author

Патч с новыми юнит тестами для проверки того, что они падают на мастере. Применять патч нужно на master ветке.

@evdokimovs
Copy link
Contributor Author

evdokimovs commented Sep 16, 2020

FCM

Fix RpcClient reference leak in Jason (#140, #27)

@evdokimovs evdokimovs marked this pull request as ready for review September 16, 2020 11:47
@evdokimovs evdokimovs changed the title Draft: Fix RpcClient reference leak (#27) Fix RpcClient reference leak (#27) Sep 16, 2020
@evdokimovs evdokimovs requested a review from alexlapa September 16, 2020 11:48
@tyranron tyranron removed the bug Something isn't working label Sep 17, 2020
@evdokimovs evdokimovs changed the title Fix RpcClient reference leak (#27) Fix RpcClient reference leak in Jason (#27) Sep 17, 2020
@evdokimovs evdokimovs merged commit a312b38 into master Sep 17, 2020
@evdokimovs evdokimovs deleted the fix-rpc-leak branch September 17, 2020 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::testing Related to testing and/or automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants