Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Wait for OnJoin callback result when accepting RpcConnection #153

Merged
merged 11 commits into from
Oct 18, 2020
Merged

Wait for OnJoin callback result when accepting RpcConnection #153

merged 11 commits into from
Oct 18, 2020

Conversation

alexlapa
Copy link
Collaborator

@alexlapa alexlapa commented Oct 16, 2020 •
edited by tyranron
Loading

Synopsis

В данный момент все коллбеки стреляют по принципу fire and forget. Для OnLeave это приемлимое поведение, но в случае с OnJoin будет правильнее ожидать ответа, таким образом CallbackServer получит возможность контроллировать процесс подключения пользователя к комнате.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) labels Oct 16, 2020
@alexlapa alexlapa added this to the 0.2.0 milestone Oct 16, 2020
@alexlapa alexlapa self-assigned this Oct 16, 2020
@alexlapa
Copy link
Collaborator Author

alexlapa commented Oct 16, 2020 •
edited by tyranron
Loading

FCM:

Wait for OnJoin Control API callback result when accepting RpcConnection (#153)

@alexlapa alexlapa marked this pull request as ready for review October 16, 2020 11:33
@alexlapa alexlapa requested a review from tyranron October 16, 2020 11:34
@tyranron tyranron changed the title Draft: Wait for OnJoin callback result when accepting RpcConnection Wait for OnJoin callback result when accepting RpcConnection Oct 17, 2020
@tyranron
Copy link
Member

ack @xDarksome

@alexlapa alexlapa merged commit e3f8d69 into master Oct 18, 2020
@alexlapa alexlapa deleted the wait-on-join-result branch October 18, 2020 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlapa @tyranron