Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Rename mute/unmute to enable/disable (#27) #155

Merged
merged 11 commits into from
Nov 13, 2020
Merged

Rename mute/unmute to enable/disable (#27) #155

merged 11 commits into from
Nov 13, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Nov 5, 2020 •
edited
Loading

Part of #27

Required for #156

Synopsis

It was decided that current muting mechanism more about MediaStreamTracks enabling/disabling, so muting/unmuting naming now out of date.

Solution

Rename all mute/unmute related things to enable/disable naming.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::documentation Related to project documentation k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Nov 5, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Nov 5, 2020
@evdokimovs evdokimovs self-assigned this Nov 5, 2020
@evdokimovs evdokimovs mentioned this pull request Nov 5, 2020
Merged
16 tasks
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Nov 5, 2020 •
edited
Loading

FCM

Rename mute/unmute to enable/disable (#155, #27)

Additionally:
- upgrade Firefox to 82.0.2 version for E2E tests

@evdokimovs evdokimovs marked this pull request as ready for review November 5, 2020 17:00
@evdokimovs evdokimovs changed the title Draft: Rename mute to disable (#27) Draft: Rename mute/unmute to enable/disable (#27) Nov 5, 2020
@evdokimovs evdokimovs requested a review from alexlapa November 6, 2020 09:02
alexlapa and others added 6 commits November 11, 2020 14:15
@alexlapa
Merge branch 'master' into rename-mute-to-disable
91b6a85 
# Conflicts:
#	CHANGELOG.md
#	jason/CHANGELOG.md
#	jason/src/api/room.rs
#	jason/src/peer/media/mod.rs
#	jason/src/peer/media/mute_state/controller.rs
#	jason/src/peer/media/sender.rs
#	jason/src/peer/mod.rs
#	jason/tests/api/room.rs
#	jason/tests/peer/media.rs
#	jason/tests/peer/mod.rs
@alexlapa
fix merge
b1cf1dc
@alexlapa
add todos
70bb87a
@evdokimovs
Refactor is_disabled to is_enabled
05dc56c
@evdokimovs
Minor fixes [run ci]
d63b3a6
@alexlapa
refactor [run ci]
b532c5b
@evdokimovs evdokimovs requested a review from tyranron November 12, 2020 15:55
@tyranron tyranron changed the title Draft: Rename mute/unmute to enable/disable (#27) Rename mute/unmute to enable/disable (#27) Nov 13, 2020
@evdokimovs evdokimovs merged commit ad6a63a into master Nov 13, 2020
@evdokimovs evdokimovs deleted the rename-mute-to-disable branch November 13, 2020 10:27
@alexlapa alexlapa removed their request for review November 16, 2020 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::documentation Related to project documentation k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa