Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Fix OsSignal for GracefulShutdown, fix default shutdown.timeout in docs #37

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

alexlapa
Copy link
Collaborator

@alexlapa alexlapa commented Jul 18, 2019

Resolves #29

Synopsis

  1. Wrong default shutdown.timeout config.toml
  2. Handler for GracefulShutdown do not send messages to sub

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::deploy Related to deployment capabilities labels Jul 18, 2019
@alexlapa alexlapa self-assigned this Jul 18, 2019
@alexlapa alexlapa added this to the 0.1.0 milestone Jul 18, 2019
@alexlapa alexlapa mentioned this pull request Jul 18, 2019
@alexlapa alexlapa merged commit c02e701 into master Jul 18, 2019
@alexlapa alexlapa deleted the 29-fix-gracefull-shutdown branch July 18, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix k::deploy Related to deployment capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful shutdown
1 participant