Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Use String in TURN address #42

Merged
merged 5 commits into from
Aug 6, 2019
Merged

Use String in TURN address #42

merged 5 commits into from
Aug 6, 2019

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Aug 5, 2019 •
edited
Loading

Synopsis

Change type of TURN address from IpAddr to String.

Solution

  • Change config field and all affected fields of TURN service
  • Rename fields from ip to host

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::config Related to application configuration labels Aug 5, 2019
@evdokimovs evdokimovs added this to the 0.1.0 milestone Aug 5, 2019
@evdokimovs evdokimovs self-assigned this Aug 5, 2019
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Aug 5, 2019 •
edited by tyranron
Loading

FCM

Replace 'turn.ip' config option with 'turn.host' (#42)

@evdokimovs evdokimovs requested a review from alexlapa August 5, 2019 09:36
@alexlapa alexlapa requested a review from tyranron August 6, 2019 12:41
@alexlapa alexlapa mentioned this pull request Aug 6, 2019
Closed
5 tasks
tyranron
tyranron approved these changes Aug 6, 2019
View reviewed changes
src/conf/turn.rs Outdated
pub ip: IpAddr,
/// Host address STUN/TURN server. Defaults to `localhost`.
#[default("localhost".to_string())]
pub host: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use Cow in config as it's much more ergonomic.

@evdokimovs evdokimovs changed the title WIP: Use String in TURN address Use String in TURN address Aug 6, 2019
@evdokimovs evdokimovs merged commit c96d9f6 into master Aug 6, 2019
@evdokimovs evdokimovs deleted the use-string-for-turn branch August 6, 2019 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::config Related to application configuration
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa