This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Control API gRPC callbacks for Member (#61) #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCM
|
# Conflicts: # jason/e2e-demo/js/index.js
alexlapa
approved these changes
Dec 6, 2019
tyranron
suggested changes
Dec 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall implementation feels quite raw and unpolished. You should spend more time on polishing and self-reviewing this.
alexlapa
approved these changes
Dec 10, 2019
# Conflicts: # mock/control-api/src/main.rs
tyranron
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not without corrections, but majorly good 👍
tyranron
changed the title
WIP: Control API gRPC callbacks for Member (#61)
Control API gRPC callbacks for Member (#61)
Dec 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #61
Part of #27
Synopsis
In
0001-control-api
RFC exists callback mechanism but currently it doesn't implemented. In this PR will be implemented onlyon_join
andon_leave
gRPC callbacks.Solution
medea-control-api-proto
medea-control-api-mock
with gRPC callback server mockon_join
andon_leave
callbacks sendinge2e-demo
's Control API UIChecklist
WIP:
prefixk::
labels appliedWIP:
prefix is removed