Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement commands validation #86

Merged
merged 10 commits into from
Feb 25, 2020
Merged

Implement commands validation #86

merged 10 commits into from
Feb 25, 2020

Conversation

alexlapa
Copy link
Collaborator

@alexlapa alexlapa commented Feb 23, 2020 •
edited by tyranron
Loading

Synopsis

В текущей реализации комната будет принимать и пытаться обработать различные варианты невалидных комманд:

  1. Комманда содержит peer_id более не существующего пира, что наблюдалось в рамках тестирования medea-demo, когда PeersRemoved уже идет, но клиент все-еще успевает отправить комманды по этому пиру.
  2. Комманда содержит peer_id, который не принадлежит отправившему ее клиенту.

Solution

Реализовать валидацию всех получаемых комнатой комманд, игнорировать невалидные комманды.

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa self-assigned this Feb 23, 2020
@alexlapa alexlapa added feature New feature or request k::api Related to API (application interface) k::security Related to security labels Feb 23, 2020
@alexlapa
Copy link
Collaborator Author

alexlapa commented Feb 23, 2020 •
edited by tyranron
Loading

FCM:

Implement commands validation (#86)

- ignore commands that reference unknown Peer
- ignore commands that reference Peer not owned by Member that sends command

Additionally:
- fix rustc warnings in 'medea-reactive' tests
- fix missing Eq derive in 'medea-client-api-proto'

@alexlapa alexlapa added this to the 0.2.0 milestone Feb 23, 2020
@alexlapa alexlapa requested a review from tyranron February 23, 2020 10:47
@alexlapa alexlapa marked this pull request as ready for review February 23, 2020 10:47
@tyranron tyranron changed the title WIP: Implement commands validation Implement commands validation Feb 25, 2020
@tyranron tyranron added enhancement Improvement of existing features or bugfix and removed feature New feature or request labels Feb 25, 2020
@alexlapa alexlapa merged commit ea8d02c into master Feb 25, 2020
@alexlapa alexlapa deleted the impl-room-commands-validation branch February 25, 2020 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::security Related to security
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlapa @tyranron