Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add service for Coturn stats #94

Merged
merged 27 commits into from
Mar 30, 2020
Merged

Add service for Coturn stats #94

merged 27 commits into from
Mar 30, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Mar 23, 2020

Part of #27

Required for #91

Synopsis

We need to process Coturn's stats for the on_start/on_stop Control API callbacks (#91). This PR adds service which will fetch and deserialize all Coturn stats events.

Also we need to change algorithm of a new Coturn user creating. Now Coturn users will be created individually for all PeerConnections. This is needed for convenient processing of a PeerConnection's Coturn stats.

Solution

  • 1. Change algorithm of a new Coturn user creating
  • 2. Add CoturnStats service
    • 2.1. Coturn events deserialization
    • 2.2. Reconnection to a Coturn stats Redis server
    • 3.3. Detecting PeerConnection's traffic starting and allocations deleting

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::monitoring Related to monitoring capabilities labels Mar 23, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Mar 23, 2020
@evdokimovs evdokimovs self-assigned this Mar 23, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Mar 23, 2020

FCM

Add service for Coturn stats (#94, #27)

- register Coturn credentials for each peer
- add service for Coturn stats processing

@evdokimovs evdokimovs marked this pull request as ready for review March 23, 2020 12:29
@evdokimovs evdokimovs requested a review from alexlapa March 23, 2020 12:35
@alexlapa alexlapa requested a review from tyranron March 27, 2020 09:59
@tyranron tyranron added k::design Related to overall design and/or architecture enhancement Improvement of existing features or bugfix labels Mar 30, 2020
@tyranron tyranron changed the title WIP: Add service for the Coturn stats Add service for Coturn stats Mar 30, 2020
@alexlapa alexlapa merged commit 06db43d into master Mar 30, 2020
@alexlapa alexlapa deleted the coturn-stats-service branch March 30, 2020 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::design Related to overall design and/or architecture k::monitoring Related to monitoring capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants