-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Add Token Exchange Grant Type (RFC8693) #1052
Draft
blairdrummond
wants to merge
25
commits into
int128:master
Choose a base branch
from
blairdrummond:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add token-exchange auth flow support (RFC 8693)
I'm eager to try using this approach with Gitlab CI job tokens and Keycloak as an OIDC broker. How much is left to do before this will be usable? |
I haven't forgotten about this work but have been really busy. I'll try to take a look some time this fall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this work-in-progress PR, my colleague and I started working on this a few weeks ago but had to set it down. I'm going to try to get this ramped back up over the next week, just opening this draft to get the conversation going.
Dex just released Token Exchange support, which we use to authenticate github actions pipelines against Kubernetes and ArgoCD (original PR here). I have been rolling bespoke token exchange code for a while but want to get this merged into KubeLogin if I can so that I can use kubelogin for human and machine authentication to k8s and argocd.
In another branch we're working to refactor stuff to more closely match the style of the existing codebase, but that branch is not in a working state yet.
Anyway! I will continue updates in this PR and will try to get this wrapped up hopefully by end of next weekend