Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New github_ip_allow_list_entry resource #2396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lyoung-confluent
Copy link

@lyoung-confluent lyoung-confluent commented Sep 20, 2024

Partially resolves #1067 by implementing a new github_ip_allow_list_entry resource which can be used to manage individual entries in GitHub's IP allow list functionality for an Organization, Enterprise or a GitHub App, ex:

data "github_organization" "demo" {
	name         = "my-super-secure-organization"
	summary_only = true
}

resource "github_ip_allow_list_entry" "demo" {
	value  = "127.0.0.1"
	name   = "Trust super-secure localhost"
	owner  = data.github_organization.demo.node_id
}

I would like to also add a github_organization_ip_allow_list resource in the future as described in #1067 which would manage the enabled/disabled setting for an organization. It would also be authoritative for all entries in the IP allowlist for an organization instead of managing individual entries (i.e. if an entry is added outside of Terraform it would be removed), but this PR is a good start on this/building block.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Manage Organization IP Allow Lists
1 participant