This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
Added mutex to BluetoothManager #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
ghost
reviewed
Sep 4, 2018
| @@ -206,6 +206,7 @@ std::weak_ptr<BluetoothEvent> BluetoothManager::find(BluetoothType type, | |||
| void BluetoothManager::handle_event(BluetoothType type, std::string *name, | |||
| std::string *identifier, BluetoothObject *parent, BluetoothObject &object) | |||
| { | |||
| std::lock_guard<std::mutex> guard(lock); | |||
There was a problem hiding this comment.
Hi.
Is it possible, that add_event/remove_event API will be called in scope of callback (line 232). If so, crash will occur because 'event_list' will be modified during the iteration. To avoid this copy on write semantics should be implemented.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the issue #113.
A mutex and guard_locks are added in BluetoothManager to synchronize the access to the event_list.
I'm not a C++ expert, so please check it before merging!
Signed-off-by: pierantoniomerlino [email protected]