Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Change the structure of notebooks directory. #48

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Calculuser
Copy link

No description provided.

README.md Outdated
12. [LSTM](https://github.com/intel-analytics/BigDL-Tutorials/blob/master/notebooks/neural_networks/lstm.ipynb)
13. [Bi-directional RNN](https://github.com/intel-analytics/BigDL-Tutorials/blob/master/notebooks/neural_networks/birnn.ipynb)
14. [Auto-encoder](https://github.com/intel-analytics/BigDL-Tutorials/blob/master/notebooks/neural_networks/autoencoder.ipynb)
1. RDD [Python](https://github.com/intel-analytics/BigDL-Tutorials/blob/master/notebooks/python/spark_basics/RDD.ipynb)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to display as RDD [Python], RDD [Python | Scala]

@yiheng
Copy link

yiheng commented Feb 1, 2018

sc.stop()

does the user need to restart the toree?

@Calculuser
Copy link
Author

No. User does not need to restart Toree.

@yiheng
Copy link

yiheng commented Feb 2, 2018

But user cannot use sc anymore in the notebook, right?

@yiheng
Copy link

yiheng commented Feb 2, 2018

val trainSet = 
    DataSet.array(load(trainData, trainLabel), sc) -> BytesToGreyImg(28, 28) -> GreyImgNormalizer(trainMean, trainStd) -> GreyImgToBatch(batchSize)
val validationSet = 
    DataSet.array(load(validationData, validationLabel), sc) -> BytesToGreyImg(28, 28) -> GreyImgNormalizer(testMean, testStd) -> GreyImgToBatch(batchSize)

Please load the data as RDD format

@yiheng
Copy link

yiheng commented Feb 2, 2018

//Parameters
val batchSize = 2048
val learningRate = 0.2
val maxEpochs = 15

//Network Parameters
val nInput = 784 //MNIST data input (img shape: 28*28)
val nClasses = 10  //MNIST total classes (0-9 digits)

why put this piece of code in the MNIST notebook?

@yiheng
Copy link

yiheng commented Feb 2, 2018

Please remove the linear_regression and Logistic Regression
notebooks. It's hard two review as github for notebook review is not easy to use. Let't put one notebook in one PR.

@yiheng
Copy link

yiheng commented Feb 2, 2018

val trainData = "../datasets/mnist/train-images-idx3-ubyte"
val trainLabel = "../datasets/mnist/train-labels-idx1-ubyte"
val validationData = "../datasets/mnist/t10k-images-idx3-ubyte"
val validationLabel = "../datasets/mnist/t10k-labels-idx1-ubyte"

You need tell user put the data file in ../datasets/mnist/...

I think this is not user friendly, can you provide a utility to download the mnist dataset just like python notebook?

@yiheng yiheng self-requested a review February 2, 2018 02:29
@Calculuser
Copy link
Author

Yes. In this specific notebook. user cannot use sc any more. But when user switches to another notebook, it works normally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants