qgs: add --verbose & --debug parameters to control logging #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel P. Berrangé <[email protected]>
The sgx_proc_log_report() method takes a format string and var-args. It is unsafe to accept a non-const string from the QL library and pass it to sgx_proc_log_report(), as the log message may contain format strings from user data. Signed-off-by: Daniel P. Berrangé <[email protected]>
Currently qgs prints all log messages to syslog or stderr unconditionally, even those at QGS_LOG_LEVEL_INFO. At the same time it hardcodes SGX_QL_LOG_ERROR for the quote provider library making it impossible to debug that part of the code. This adds --verbose and --debug parameters to QGS with the following behaviour * Messages from QGS code at QGS_LOG_LEVEL_INFO are discarded unless --verbose is set. This makes QGS quiet by default, only printing warnings/errors. * Messages from the quote provider library are requested at SGX_QL_LOG_INFO instead of SGX_QL_LOG_ERROR if --debug is set. This output is very volumous, dumping HTTP request and response info, hence putting it behind --debug, instead of enabling it with the former --verbose flag. * Enabling --debug will imply --verbose, so setting both is redundant, albeit harmless Signed-off-by: Daniel P. Berrangé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interesting stuff is in the third commit...
Currently qgs prints all log messages to syslog or stderr unconditionally, even those at QGS_LOG_LEVEL_INFO. At the same time it hardcodes SGX_QL_LOG_ERROR for the quote provider library making it impossible to debug that part of the code.
This adds --verbose and --debug parameters to QGS with the following behaviour
is set. This output is very volumous, dumping HTTP request and response info, hence putting it behind --debug, instead of enabling it with the former --verbose flag.
The first two commits just fix two tiny bugs