-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fixed a few links in manual.md #4687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always appreciate improved links, BUT:
- I think if the desired parameter is a file for both, let's go with SBOM_FILENAME and VEX_FILENAME rather than having either of them be OUTPUT.
- We should change these in the code as well so that the help text matches whatever's in the manual
- Once the code is changed, you'll need to make update the sections where we list arguments (in MANUAL.md and README.md) to match what
cve-bin-tool --help
actually generates.
But your instinct to at least fix the parameter names is a good one, and can be done now! Let's just make them both FILENAME instead of OUPTUT.
Ok @terriko i guess i get, i'll get it done |
HI @terriko, I don't really understand why the tests are failing here, i'd really appreciate your help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test fails are un-related to this PR so I'm going to merge it now. Thanks for working on this!
BUT if you're curious: I think the failures are being caused by our cache job sometimes getting killed before the cache updates, probably related to the Out of Memory issue discussed in #4592
I'm going to do a bit of debugging today and see if we can tune things a bit better, but I'm not sure where to start yet.
I have gotten the cache to update correctly and have re-run the required test. This is set to merge when it passes. |
Fixed few links and their order, also changed the name to make it little more consistant
let me know if anything else is needed
Thanks