Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NPU] Further fix saving of generation config #12657

Merged
merged 3 commits into from
Jan 7, 2025
Merged

[NPU] Further fix saving of generation config #12657

merged 3 commits into from
Jan 7, 2025

Conversation

Oscilloscope98
Copy link
Contributor

@Oscilloscope98 Oscilloscope98 commented Jan 6, 2025 •
edited
Loading

Description

Fix saving of generation config for llama/minicpm (Python {C++ backend))

plusbang
plusbang approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@plusbang plusbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oscilloscope98 Oscilloscope98 merged commit ebdf19f into intel:main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plusbang plusbang plusbang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oscilloscope98 @plusbang