Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix creating releases job #144

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

eparshut
Copy link
Contributor

@eparshut eparshut commented May 6, 2024

After upgrading the upload-artifact action from v3 to v4 the release creation workflow was broken (see #126).

These changes adapt our release workflow to have a unique os-based name for each uploaded artifact and filter downloads by name pattern regarding the migration document: https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

Also exclude PT support from the macOS build since the latest macOS images are on arm architecture (PT is only supported on x86)

@eparshut eparshut requested a review from abrown May 6, 2024 10:53
Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @eparshut for the fix.

@abrown abrown merged commit 5aaa4b0 into intel:master May 6, 2024
12 checks passed
@abrown abrown mentioned this pull request May 6, 2024
@eparshut eparshut deleted the github_actions branch June 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants