[SPIR-V] Reland "Fix OpGroupNonUniformBroadcast version requirement" #16854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SPIR-V 1.4 and earlier, the Id operand of OpGroupNonUniformBroadcast must come from a constant instruction. Ensure that any emitted SPIR-V module using a non-constant Id operand declares SPIR-V version 1.5. Bail out if the maximum SPIR-V version was restricted to < 1.5, to avoid producing invalid SPIR-V. Original commit: KhronosGroup/SPIRV-LLVM-Translator@64fe75e388dc3b7 This reverts commit bbf3800 The reland is possible after switch to SPIR-V 1.5
vmaksimo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vmaksimo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SPIR-V 1.4 and earlier, the Id operand of
OpGroupNonUniformBroadcast must come from a constant instruction.
Ensure that any emitted SPIR-V module using a non-constant Id operand declares SPIR-V version 1.5. Bail out if the maximum SPIR-V version was restricted to < 1.5, to avoid producing invalid SPIR-V.
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@64fe75e388dc3b7
This reverts commit bbf3800 The reland is possible after switch to SPIR-V 1.5