date and naming fixes

intel · Jan 31, 2025 · 22557be · 22557be
1 parent f637956
commit 22557be
Show file tree

Hide file tree

Showing 19 changed files with 26 additions and 21 deletions.
diff --git a/lib/src/arbiters/arbiter.dart b/lib/src/arbiters/arbiter.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // arbiter.dart

diff --git a/lib/src/arbiters/mask_round_robin_arbiter.dart b/lib/src/arbiters/mask_round_robin_arbiter.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // mask_round_robin_arbiter.dart

diff --git a/lib/src/arbiters/priority_arbiter.dart b/lib/src/arbiters/priority_arbiter.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // priority_arbiter.dart

diff --git a/lib/src/arbiters/rotate_round_robin_arbiter.dart b/lib/src/arbiters/rotate_round_robin_arbiter.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // rotate_round_robin_arbiter.dart

diff --git a/lib/src/arbiters/stateful_arbiter.dart b/lib/src/arbiters/stateful_arbiter.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // stateful_arbiter.dart

diff --git a/lib/src/arithmetic/divider.dart b/lib/src/arithmetic/divider.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2024 Intel Corporation
+// Copyright (C) 2024-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // divider.dart

diff --git a/lib/src/arithmetic/float_to_fixed.dart b/lib/src/arithmetic/float_to_fixed.dart
@@ -10,8 +10,6 @@
 import 'package:rohd/rohd.dart';
 import 'package:rohd_hcl/rohd_hcl.dart';
 
-// TODO(desmonddak): Should FloatToFixed be abstract?
-
 /// [FloatToFixed] converts a floating point input to a signed
 /// fixed-point output following Q notation (Qm.n format) as introduced by
 /// (Texas Instruments)[https://www.ti.com/lit/ug/spru565b/spru565b.pdf].

diff --git a/lib/src/arithmetic/floating_point/floating_point_multiplier_simple.dart b/lib/src/arithmetic/floating_point/floating_point_multiplier_simple.dart
@@ -35,7 +35,9 @@ class FloatingPointMultiplierSimple extends FloatingPointMultiplier {
       super.name})
       : super(
             definitionName: 'FloatingPointMultiplierSimple_'
-                'E${a.exponent.width}M${a.mantissa.width}') {
+                'E${a.exponent.width}M${a.mantissa.width}'
+                '${outProduct != null ? '_OE${outProduct.exponent.width}_'
+                    'OM${outProduct.mantissa.width}' : ''}') {
     if (exponentWidth < a.exponent.width) {
       throw RohdHclException('product exponent width must be >= '
           ' input exponent width');

diff --git a/lib/src/arithmetic/ripple_carry_adder.dart b/lib/src/arithmetic/ripple_carry_adder.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // ripple_carry_adder.dart

diff --git a/lib/src/binary_gray.dart b/lib/src/binary_gray.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // binary_gray.dart

diff --git a/lib/src/edge_detector.dart b/lib/src/edge_detector.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2024 Intel Corporation
+// Copyright (C) 2024-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // edge_detector.dart
@@ -40,7 +40,7 @@ class EdgeDetector extends Module {
     String? name,
   }) : super(
             name: name ?? '${edgeType.name}_edge_detector',
-            definitionName: 'EdgeDetector_W${signal.width}') {
+            definitionName: 'EdgeDetector_T${edgeType.name}') {
     if (signal.width != 1 ||
         (resetValue is Logic && resetValue.width != 1) ||
         (resetValue is LogicValue && resetValue.width != 1)) {

diff --git a/lib/src/encodings/one_hot_to_binary.dart b/lib/src/encodings/one_hot_to_binary.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // one_hot_to_binary.dart

diff --git a/lib/src/memory/memory.dart b/lib/src/memory/memory.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // memory.dart

diff --git a/lib/src/rotate.dart b/lib/src/rotate.dart
@@ -42,7 +42,7 @@ abstract class _Rotate extends Module {
       {int? maxAmount, super.name = 'rotate'})
       : maxAmount = min(maxAmount ?? original.width,
             pow(2, rotateAmount.width).toInt() - 1),
-        super(definitionName: '_Rotate_${_direction}_W${original.width}') {
+        super(definitionName: 'Rotate_${_direction.name}_W${original.width}') {
     original = addInput('original', original, width: original.width);
     rotateAmount =
         addInput('rotate_amount', rotateAmount, width: rotateAmount.width);
@@ -108,7 +108,9 @@ class _RotateFixed extends Module {
   /// Rotates [original] by [rotateAmount] to the [_direction].
   _RotateFixed(this._direction, Logic original, this.rotateAmount,
       {super.name = 'rotate_fixed'})
-      : super(definitionName: 'rotate_${_direction.name}_by_$rotateAmount') {
+      : super(
+            definitionName: 'RotateFixed_${_direction.name}_'
+                'by_$rotateAmount') {
     original = addInput('original', original, width: original.width);
     addOutput('rotated', width: original.width);
 

diff --git a/lib/src/serialization/deserializer.dart b/lib/src/serialization/deserializer.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2025 Intel Corporation
+// Copyright (C) 2024-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // deserializer.dart

diff --git a/lib/src/serialization/serializer.dart b/lib/src/serialization/serializer.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2025 Intel Corporation
+// Copyright (C) 2024-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // serializer.dart

diff --git a/lib/src/shift_register.dart b/lib/src/shift_register.dart
@@ -55,7 +55,8 @@ class ShiftRegister extends Module {
   })  : width = dataIn.width,
         super(
             name: '${dataName}_shift_register',
-            definitionName: 'ShiftRegister_W${dataIn.width}') {
+            definitionName: 'ShiftRegister_W${dataIn.width}'
+                '_D$depth') {
     dataIn = addInput('${dataName}_in', dataIn, width: width);
     clk = addInput('clk', clk);
 

diff --git a/test/arithmetic/floating_point/floating_point_multiplier_test.dart b/test/arithmetic/floating_point/floating_point_multiplier_test.dart
@@ -10,6 +10,7 @@
 //
 
 import 'dart:async';
+import 'dart:io';
 import 'dart:math';
 import 'package:rohd/rohd.dart';
 import 'package:rohd_hcl/rohd_hcl.dart';
@@ -295,6 +296,7 @@ void main() {
       final multiply =
           FloatingPointMultiplierSimple(fp1, fp2, outProduct: fpout);
       await multiply.build();
+      File('widem.sv').writeAsStringSync(multiply.generateSynth());
       final computed = multiply.product.floatingPointValue;
 
       expect(computed, equals(expected), reason: '''

diff --git a/test/configurator_test.dart b/test/configurator_test.dart
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2024 Intel Corporation
+// Copyright (C) 2023-2025 Intel Corporation
 // SPDX-License-Identifier: BSD-3-Clause
 //
 // configurator_test.dart