Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes to the memory model #72

Merged
merged 1 commit into from
Jan 17, 2024
Merged

More fixes to the memory model #72

merged 1 commit into from
Jan 17, 2024

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

This PR fixes some more bugs related to the memory model and adds more tests to catch the issues. Mainly:

  • A read immediately following a write with zero-latency could result in old data being returned.
  • A read on non-zero-latency could sometimes return data for a new address instead of the posedge sampled address.

Related Issue(s)

N/A

Testing

Added a bunch of new testing

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit 6b8326d into intel:main Jan 17, 2024
4 checks passed
@mkorbel1 mkorbel1 deleted the memmodfix2 branch January 17, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant