Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set USE_XCCL default as OFF #1318

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Set USE_XCCL default as OFF #1318

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ed3e6d
Set USE_XCCL default as OFF
Chao1Han Jan 22, 2025
de7fd8d
add build flag in ci
Chao1Han Jan 24, 2025
c9c1b6e
Merge branch 'main' into xccl/off
Chao1Han Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ list(APPEND CMAKE_MODULE_PATH ${TORCH_XPU_OPS_ROOT}/cmake/Modules)
include(${TORCH_XPU_OPS_ROOT}/cmake/SYCL.cmake)
include(${TORCH_XPU_OPS_ROOT}/cmake/BuildFlags.cmake)

option(USE_XCCL "Build with XCCL support" ON)
option(USE_XCCL "Build with XCCL support" OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, XCCL backend does not get ready in PyTorch release. So we disable it by default (you still can build XCCL with USE_XCCL=1) and will enable again in PyTorch 2.8 release by our expectation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite unfortunate since a number of projects awaits distributed support fromXPU. What are outstanding issues preventing to enable XCCL by default?


if(NOT WIN32 AND USE_XCCL)
include(${TORCH_XPU_OPS_ROOT}/cmake/XCCL.cmake)
Expand Down