batch_normalization: Introduce vectorization optimization in the batch norm elementwise kernel. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuan14
changed the title
fengyuan14
changed the title
fengyuan14
reviewed
Oct 15, 2024
| for (int vt = 0; vt < VEC_SIZE; ++vt) { | ||
| index_t feature = feature_vec_begin + vt; | ||
| vec[vt] = static_cast<input_scalar_t>( | ||
| gamma * (i[feature] - mean) * invstd + beta); |
There was a problem hiding this comment.
Why not using vectorization for inputs? I see vt is contiguous across the iteration.
There was a problem hiding this comment.
In the CNL case, consecutive work-items cannot access consecutive data for the OffsetCalculator is used for calculating loading stride.
There was a problem hiding this comment.
If we know the vt size, we can calculate offset with linear id 0, 3, 7, 11? if the vt size is 4?
fengyuan14
reviewed
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to performance issues with the low-precision data type implementation of group stride loops on PVC (jira: PYTORCHDGQ-5162), partial vectorization optimization is used.