Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply PEP8 #60

Closed
wants to merge 7 commits into from
Closed

Apply PEP8 #60

wants to merge 7 commits into from

Conversation

ayham-1
Copy link

@ayham-1 ayham-1 commented Oct 23, 2019

Closes: #59

@pep8speaks
Copy link

pep8speaks commented Oct 23, 2019 •
edited
Loading

Hello @realaltffour! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:1: E731 do not assign a lambda expression, use a def

Comment last updated at 2019-10-23 18:00:45 UTC

@ayham-1 ayham-1 mentioned this pull request Oct 23, 2019
Open
@yochannah
Copy link
Member

@realaltffour it looks like there are still a few minor errors in query.py - the comment above from pep8 speaks will update when it is fixed to say all is good :)

@ayham-1
Fix list.py and listmanager.py
fb35f0e
@ayham-1
Fix files to PEP8
25abaf7
@ayham-1
Apply PEP8 on sample
ef92d1f
@ayham-1
Add comments for new functions.
b7306a7 
- Add comments for identity()
- Add comments for flatFileParser()
- Add comments for simpleJSONParser()
@ayham-1
Fix project not building.
7fe3889
@ayham-1 ayham-1 closed this Oct 23, 2019
@ayham-1
Copy link
Author

ayham-1 commented Oct 23, 2019

I would make a new PR after I have got my branch correctly built, I would suggest for this PR to be deleted.

@yochannah
Copy link
Member

yochannah commented Oct 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[easier issue if you know python] apply pep8 formatting to all files
3 participants
@ayham-1 @pep8speaks @yochannah