Apply suggestions from code review

internetarchive · Oct 24, 2023 · dc742af · dc742af
1 parent 163df60
commit dc742af
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/openlibrary/plugins/openlibrary/js/breadcrumb_select/index.js b/openlibrary/plugins/openlibrary/js/breadcrumb_select/index.js
@@ -6,13 +6,13 @@
 export function initBreadcrumbSelect(crumbs) {
     const allowedKeys = new Set(['Tab', 'Enter', ' ']);
     const preventedKeys = new Set(['ArrowUp', 'ArrowDown']);
-
+    // watch crumbs for changes,
+    // ensures it's a full value change, not a user exploring options via keyboard
     function handleNavEvents(nav) {
         let ignoreChange = false;
 
         nav.addEventListener('change', () => {
             if (ignoreChange) return;
-            // It's actually changed!
             window.location = nav.value;
         });
 

diff --git a/openlibrary/templates/books/breadcrumb_select.html b/openlibrary/templates/books/breadcrumb_select.html
@@ -40,4 +40,4 @@ <h2 class="breadcrumb-title">$breadcrumb_title</h2>
                             <option value=$url>$title</option>
                 </select>
             </span>
-        </span>
+        </span>