Bug fix #450
Open
Bug fix #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ExplainerBase.generate_counterfactuals arguments proximity_weight, sparsity_weight, diversity_weight, and categorical_penalty aren't actually used, nor passed to corresponding inherited classes.
With this fix, they can be actually passed with as kwargs.
Additionally, the method "genetic" does not work when all data is categorical, due to the proximity_loss.
This should be solvable with proximity_weight=0.0, but due to the fact that we cannot pass proximity_weight, we get the following bug:
https://colab.research.google.com/drive/1Pdd_IHo_e-ywdvQcQ_zE6jnQ2MkYcl2h#scrollTo=58x7nHNgUwkk