BUG: Fix index error when values exceed 999T #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degenfabian
force-pushed
the
fix-IndexError-when-values-exceed-999T
branch
from
cba66ad
to
4e587fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #581 +/- ##
===========================================
+ Coverage 75.77% 75.80% +0.03%
===========================================
Files 72 72
Lines 9078 9081 +3
===========================================
+ Hits 6879 6884 +5
+ Misses 2199 2197 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 3 commits
October 24, 2024 09:33
Signed-off-by: Fabian Degen <[email protected]>
Signed-off-by: Fabian Degen <[email protected]>
Signed-off-by: Fabian Degen <[email protected]>
degenfabian
force-pushed
the
fix-IndexError-when-values-exceed-999T
branch
from
1db8fe7
to
adb823d
Compare
degenfabian
changed the title
|
Thanks @degenfabian. It's great to have this finally fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is an intended fix of the bug presented in issue #370. I fixed the IndexError by falling back to using the scientific notation once values become larger than 999T. I also added a test case which tests that exact functionality and with this modification I was able to solve the IndexError.