-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: edit attributes in basket page #1508
Draft
skoch-intershop
wants to merge
5
commits into
develop
Choose a base branch
from
feature/extended-line-item-attributes-on-basket-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feature: edit attributes in basket page #1508
skoch-intershop
wants to merge
5
commits into
develop
from
feature/extended-line-item-attributes-on-basket-page
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71345d4
to
d1f8ddd
Compare
97b50c7
to
461ac20
Compare
Needs rework using customFields API |
461ac20
to
b3756df
Compare
PR will possibly replaced by a customFields implementation |
b3756df
to
e1d1f9a
Compare
Azure Demo Servers are available: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancement to an existing feature
has conflicts
wait
Waiting for something (e.g. new ICM release)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First image shows the basket page in regards of the current implementation. The first line item already contains values for partial order number and customer product id. The values are displayed as text and also the link Show more is displayed.

Clicking on this link opens a form for editing the two values. The second line item does not contain values for partial order number and customer product id. The initial form is loaded as soon as the Show more link is pressed. As long as no values are entered, the Apply button is disabled and the Cancel button is hidden.
The second image shows the input of a value into the input field. In this case the Apply button and the Cancel button are now active. The Apply button submit the form, Form will closed and new values will displayed as text. Pressing the Cancel button will also close the form.

The last image shows an example of a line item list of an order:

releated issue: 88568
IAD Proposal: https://www.figma.com/file/kI5YJizwgiN62g3oP4WCJT/Commissioning-number-%26-Customer-product-ID-fields?type=design&node-id=0-1&mode=design