feat: migration to swiper 11 #1616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Swiper library version not up to date
What Is the New Behavior?
Swiper has been set to 11.
A new angular component
ish-swiperhas been introduce to wrap swiper web-elements.Previous css has been migrate to css variable or css style injected to the shadow dom.
There was an improvement made in this commit (cbe9072) to lazily fetch product. As this used a swiper function that no longer exists, a
ish-lazy-itemgenetic component was introduced. This makes it possible to perform the same optimization with an intersectionObserver and an ng-templateDoes this PR Introduce a Breaking Change?
[x ] Yes
[ ] No
Other Information