Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: order recurrence (subscription support) #1690

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

feat: order recurrence (subscription support) #1690

wants to merge 10 commits into from

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Jun 24, 2024 •
edited
Loading

PR Type

[x] Feature

What Is the Current Behavior?

The PWA does not support recurring orders/subscriptions.

What Is the New Behavior?

The PWA supports recurring orders/subscriptions.

Does this PR Introduce a Breaking Change?

[x] No

TODOs

see IAD https://www.figma.com/design/dyViJpIjdQbAHbdhr8z6iw/Recurring-orders?node-id=3-503&t=bTzn9muQiMK1AiKi-0

  • styling for the order recurrence form
  • error handling and validation
  • specific form field to implement the "until after 50 orders" form group
  • localization (especially the german and french translations)
  • the complete recurring orders/requisitions support in my account is missing
  • prevent recurring orders for piunchout users

Other Information

AB#97622

@shauke shauke self-assigned this Jun 24, 2024
@shauke shauke force-pushed the feature/recurring_orders branch 2 times, most recently from 48251ed to 8404556 Compare June 24, 2024 20:41
@shauke shauke force-pushed the feature/recurring_orders branch from 8404556 to 17e950c Compare August 13, 2024 08:58
@shauke shauke added this to the 5.3 milestone Aug 14, 2024
@shauke shauke force-pushed the feature/recurring_orders branch from 1d1fc88 to 4be7a4a Compare August 20, 2024 12:33
@shauke shauke force-pushed the feature/recurring_orders branch from 3358318 to d4125b1 Compare August 23, 2024 16:16
@suschneider suschneider force-pushed the feature/recurring_orders branch from 7d8e9c0 to cec66f0 Compare August 29, 2024 09:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Azure Demo Servers are available:

@shauke shauke force-pushed the feature/recurring_orders branch from 5b90b6f to 9ee5d14 Compare September 19, 2024 12:25
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@M-Behr
Copy link

M-Behr commented Sep 23, 2024

  • remove desired delivery date or show error message - doesn't make sense for recurring orders, does it?
    image
  • adapt text in approval details modal in checkout - review step
  • last 5 orders are missing in recurring order details
  • padding bottom is missing in infobox in mobile view
    image

@suschneider
Copy link
Collaborator

  • remove desired delivery date - done
  • adapt text in approval details modal in checkout - review step
    In our opinion we adapted the modal as defined in the IAD

image

  • last 5 orders are missing in recurring order details - The REST API cannot provide this at the moment. But everything is prepared for this so that the last 5 orders are displayed when the REST API delivers them.
  • padding bottom is missing in infobox in mobile view - done

@mglatter mglatter requested review from mglatter and removed request for mglatter September 24, 2024 08:36
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@mglatter
Copy link
Contributor

I will ask Ami to double-check French localization. Please do not consider localizations done before approval.

@shauke shauke force-pushed the feature/recurring_orders branch from 6745253 to b82b990 Compare September 26, 2024 18:45
@shauke shauke marked this pull request as ready for review September 27, 2024 07:59
@shauke shauke changed the title feat: Order recurrence (subscription support) feat: order recurrence (subscription support) Sep 27, 2024
@shauke shauke added the feature New feature or request label Sep 27, 2024
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@suschneider suschneider force-pushed the feature/recurring_orders branch from b82b990 to 6948724 Compare September 27, 2024 08:08
@MarioVesper MarioVesper linked an issue Oct 22, 2024 that may be closed by this pull request
Order subscription missing #692
Open
@shauke shauke force-pushed the feature/recurring_orders branch from ce09d62 to ed36db2 Compare January 16, 2025 20:50
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@shauke shauke force-pushed the feature/recurring_orders branch from ed36db2 to ca8ff43 Compare January 17, 2025 12:48
@shauke shauke force-pushed the feature/recurring_orders branch from 3431315 to dd36332 Compare January 20, 2025 13:38
@suschneider suschneider force-pushed the feature/recurring_orders branch from dd36332 to 084da25 Compare January 21, 2025 10:28
@suschneider
Copy link
Collaborator

Comments are only relevant from here. All previous comments have already been edited.

shauke and others added 6 commits January 22, 2025 09:18
@shauke
feat: introduce Formly number field (quantity input with + and - butt…
36ca61c 
…ons)
@shauke
feat: introduce Formly information field for rendering any freestyle …
2cba669 
…text within generated forms
@suschneider @shauke
feat: introduce Switch component (UI element for imidiate status chan…
366d639 
…ges)

* implemented as standalone component
@shauke
feat: introduce Server Setting route guard
dc4f4df 
* checks for an enabled server setting before routing
@shauke @suschneider
feat: order recurrence (subscription support)
74b600e 
* create recurring order during checkout
* handle recurring orders in requisition/approval listings
* recurring orders listing in my account
* recurring order details

Co-authored-by: Susanne Schneider <[email protected]>
@shauke
docs: adjustments after review
ba50fa9
@shauke shauke force-pushed the feature/recurring_orders branch from 084da25 to ba50fa9 Compare January 22, 2025 08:19
mglatter
mglatter previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@mglatter mglatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization approved

@shauke shauke modified the milestones: 5.3, 6.1 Feb 12, 2025
mglatter
mglatter approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mglatter mglatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest localization approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suschneider suschneider suschneider left review comments

@mglatter mglatter mglatter approved these changes

Assignees

@shauke shauke

@suschneider suschneider

Labels
feature New feature or request has conflicts
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

Order subscription missing
4 participants
@shauke @M-Behr @suschneider @mglatter