refactor: access to the Payone language object #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of adapted API for hosted payment page configuration
SGrueber
changed the title
SGrueber
previously approved these changes
Feb 17, 2025
SGrueber
changed the title
SGrueber
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The current implementation uses an
eval()expression to resolve the Payone Client API object for localization. That's unsafe.What Is the New Behavior?
The Payone connector will be updated to provide a simplified access to this object in the Payone API using an attributed named
languageCode. The fallback uses the old response attributelanguageand extracts the locale code from it without usingeval()anymore. There are no visual changes.eval()to resolve Payone language objectDoes this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#104064