add Docker +IPM #1
Conversation
There was a problem hiding this comment.
Concerns about boilerplate aside (see intersystems/isc-json#6), will need some review from owners once they are identified - that's not me, but Evgeny reached out to me for review and I'm offering feedback anyway.
| <Export generator="Cache" version="25"> | ||
| <Document name="wsock-tutorial.ZPM"> | ||
| <Module> | ||
| <Name>wsock-tutorial</Name> |
There was a problem hiding this comment.
Learning Services should provide an appropriate package name (probably not this) if it is to be distributed/installable via IPM.
| <Description>Tutorial On WebSockets</Description> | ||
| <Packaging>module</Packaging> | ||
| <SourcesRoot>src</SourcesRoot> | ||
| <Resource Name="Chat.PKG"/> |
There was a problem hiding this comment.
Need handling for ChatClient.csp as well (e.g., creating a web application for it, with appropriate security settings - probably just Password; I'll often prepend the namespace in this case, see e.g. https://github.com/intersystems/isc-perf-ui/blob/main/module.xml).
There was a problem hiding this comment.
maybe I misunderstand your request:
the client CSP page is there in Chat.PKG - works immediately after complete startup.
Docker is there. and working for the moment (not yet on 2024.1)
all further improvement is up to the owner.
and BTW. this wouldn't be the first PR that is just copied / used in parts.
Your example of module.xml looks great. Experts will like it.
I tend to keep mine small and easy so I still understand what it does.
IPM is great but far beyond my needs
There was a problem hiding this comment.
if it is a CSP page does it need a CSP application set up too?
There was a problem hiding this comment.
Yes, that was the point. src/ChatClient.csp should be copied over to a new web application dedicated to the package, which can/should be defined in module.xml as in that example.
There was a problem hiding this comment.
Gentlemen, I'd suggest you take a look not just to module.xml
But also to the original documentation and description of this Tutorial:
and there I see:
ws = new WebSocket(((window.location.protocol === "https:")? "wss:":"ws:")
+ "//"+ window.location.host + "/csp/user/Chat.Server.cls");
It is a forward port from Cache 2016 with a lengthy discussion of the design.
https://community.intersystems.com/post/asynchronous-websockets-quick-tutorial
As I have no indication who might use this in EDU I saw no reason to change the design.
All it did was to wrap it into Docker + ZPM. And that works.
As an owner. I might do more than a few changes.
But then this would be my responsibility.
There was a problem hiding this comment.
Right - that's the websocket itself, the page that demonstrates using it is just an HTML page with a .csp extension that something should be done with. IMO this is for the owners/maintainers once they're identified.
There was a problem hiding this comment.
that's why I once titled OEX as a "flea market"
owners come and go as they like and take responsibility as they like. some discipline of a few
and in parallel - as we see - just aging.
aging is also an issue for IPM.
Not that dramatic but latent undercover.
A first approach might be a "timed approval" bound to IRIS versions to escape from version impacts.
No description provided.