Allow mapping and unmapping repos & improve zpm error output #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-shuliu
changed the title
enable command
isc-shuliu
requested review from
isc-kiyer,
isc-tleavitt,
isc-eneil,
isc-jili and
isc-jlechtne
and removed request for
isc-kiyer
isc-shuliu
changed the title
enable command
isc-tleavitt
requested changes
Dec 17, 2024
| @@ -2803,9 +2811,12 @@ ZPM(pArgs...) | |||
| Set found = 0 | |||
| While rs.%Next() { | |||
| Set $Namespace = $Zstrip(rs.%Get("Nsp"), "<>WC") | |||
| If $System.CLS.IsMthd("%IPM.Main", "Shell") { | |||
| // Some I4H containers come with %IPM.Main but the "version" command doesn't work ?! | |||
There was a problem hiding this comment.
This would probably be those with IPM mapped from HSLIB/HSCUSTOM, on older versions?
There was a problem hiding this comment.
Yes, for example, containers.intersystems.com/intersystems/irishealth-community:2024.1 has this problem in HSLIB.
isc-tleavitt
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
I added a few more minor readme tweaks; looks good to me at this point. Thanks for the quick turnaround @isc-shuliu!
isc-eneil
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
@isc-shuliu I noted a couple of typos but the code looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
enable -communitywhich resets repository settings to default and map IPM along with repo settings globallyChanged