Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of long strings in slack plugin #2464

Conversation

LittleGreenYoda42
Copy link
Contributor

@LittleGreenYoda42 LittleGreenYoda42 commented Jun 26, 2024

What Changed

Fixing the code to split long lines into shorter chunks in the slack plugin.

Why

The code was broken and the failing tests made the CI pipeline fail as well.

This change solves the failing tests in https://github.com/intuit/auto/actions/runs/9039953720/job/24843604205#step:6:296 which should unblock the PR #2459

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@LittleGreenYoda42 LittleGreenYoda42 marked this pull request as ready for review June 26, 2024 11:05
@LittleGreenYoda42 LittleGreenYoda42 changed the title fix: handling of long strings in slack fix: handling of long strings in slack plugin Jun 26, 2024
@LittleGreenYoda42
Copy link
Contributor Author

@hipstersmoothie could you have a look?

@hipstersmoothie hipstersmoothie merged commit 0509a79 into intuit:main Jun 28, 2024
5 of 7 checks passed
@github-actions github-actions bot added the patch Increment the patch version when merged label Jun 28, 2024
@LittleGreenYoda42 LittleGreenYoda42 deleted the test/fix-slack-long-line-handling branch July 1, 2024 09:22
Copy link

🚀 PR was released in v11.2.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants