Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods for QuickBooks entity operations #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mockingmoon
Copy link

I would like to contribute to this project to make it a fully-equipped Node.js client for Intuit.
I have recently worked with an Intuit QuickBooks App development for Node.js wherein I used intuit-oauth and wrote my own methods for different operations on QuickBooks. Can we integrate Intuit operations into this package? Thus everything can be found at single place and it will be Intuit's own package.
This fork currently only performs create and get operations for the most commonly used QuickBooks online entities. I am planning to work on it further to add all QuickBooks online operations and additional features to this package.
Please add me as a contributor if my proposal (and code) is acceptable to you.

I assure the following -

  1. The code written by me will follow the required standards (and I dare say the style will be almost indistinguishable from the original code, except for some variable names).
  2. All my additions are tried and tested, and will not break any existing code.

Additional explanation -
I have added realmId to OAuthClient object. This will allow a person to directly enter realmId while creating the client instance. Thus if a person has the refresh token and realmId for an app, they can directly set the realmId and refresh their access token without having to authenticate their app again.

@abisalehalliprasan
Copy link
Collaborator

Thanks, @mockingmoon . I will take a look at the PR and get back to you. Appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants