Skip to content

Commit

Permalink
Merge pull request #52 from invenia/rf/drop-deprecations
Browse files Browse the repository at this point in the history
Drop global deprecations from package
  • Loading branch information
rofinn authored Jan 18, 2020
2 parents d4b1ce0 + 3731b9c commit 7a509d2
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 23 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Impute"
uuid = "f7bf1975-0170-51b9-8c5f-a992d46b9575"
authors = ["Invenia Technical Computing"]
version = "0.3.0"
version = "0.4.0"

[deps]
IterTools = "c8e1da08-722c-5040-9ed9-7db0dc04731e"
Expand Down
19 changes: 0 additions & 19 deletions src/Impute.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,6 @@ using Tables: Tables, materializer, istable
import Base.Iterators: drop
import DataFrames: dropmissing

export impute, impute!, chain, chain!, drop, drop!, interp, interp!, ImputeError

function __init__()
sym = join(["chain", "chain!", "drop", "drop!", "interp", "interp!"], ", ", " and ")

@warn(
"""
The following symbols will not be exported in future releases: $sym.
Please qualify your calls with `Impute.<method>(...)` or explicitly import the symbol.
"""
)

@warn(
"""
The default limit for all impute functions will be 1.0 going forward.
If you depend on a specific threshold please pass in an appropriate `AbstractContext`.
"""
)
end

"""
ImputeError{T} <: Exception
Expand Down
2 changes: 1 addition & 1 deletion src/context.jl
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ weighted.
* `on_complete::Function`: a function to run when imputation is complete
"""
function Context(;
limit::Float64=0.1,
limit::Float64=1.0,
is_missing::Function=ismissing,
on_complete::Function=complete
)
Expand Down
6 changes: 4 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ using Statistics
using StatsBase
using Random

import Impute:
using Impute:
Drop,
DropObs,
DropVars,
Expand All @@ -20,7 +20,9 @@ import Impute:
SRS,
Context,
WeightedContext,
ImputeError
ImputeError,
interp,
chain


@testset "Impute" begin
Expand Down

2 comments on commit 7a509d2

@rofinn
Copy link
Member Author

@rofinn rofinn commented on 7a509d2 Jan 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/8137

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.0 -m "<description of version>" 7a509d26ae7e2250f287b8ff446e1886e763379e
git push origin v0.4.0

Please sign in to comment.