Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: standardize identity icon display #1519

Closed
wants to merge 1 commit into from
Closed

CSS: standardize identity icon display #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/user_dashboard/uploads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ export const RDMRecordResultsListItem = ({ result, index }) => {
<Item.Header as="h2">
<a href={viewLink}>{title}</a>
</Item.Header>
<Item.Meta className="creatibutors">
<Item className="creatibutors">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the .Meta removed? It seems to remove the top margin if changed to just Item?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds the meta and ui classes, and some styles cascading to the children that aren't present for creatibutors lists elsewhere. To keep it, we could override or otherwise take them into account, and then add "Meta" wherever there is a creatibutor list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case I would suggest to try this

Suggested change
<Item className="creatibutors">
<Item.Meta>
<div className="creatibutors"

<SearchItemCreators creators={creators} />
</Item.Meta>
</Item>
<Item.Description>
{_truncate(description_stripped, {
length: 350,
Expand Down
6 changes: 3 additions & 3 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function SearchItemCreators({ creators }) {
title={`${creatorName}: ${i18next.t("ORCID profile")}`}
>
<img
className="inline-id-icon"
className="ml-5 inline-id-icon"
src="/static/images/orcid.svg"
alt=""
/>
Expand All @@ -74,7 +74,7 @@ export function SearchItemCreators({ creators }) {
title={`${creatorName}: ${i18next.t("ROR profile")}`}
>
<img
className="inline-id-icon"
className="ml-5 inline-id-icon"
src="/static/images/ror-icon.svg"
alt=""
/>
Expand All @@ -89,7 +89,7 @@ export function SearchItemCreators({ creators }) {
title={`${creatorName}: ${i18next.t("GND profile")}`}
>
<img
className="inline-id-icon"
className="ml-5 inline-id-icon"
src="/static/images/gnd-icon.svg"
alt=""
/>
Expand Down
3 changes: 2 additions & 1 deletion invenio_app_rdm/theme/assets/semantic-ui/less/invenio_app_rdm/theme/elements/icon.overrides
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
***********************************************/

.inline-id-icon {
height: @fontSizeBase;
height: 1rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to rename the class to open-id-branding (and all it's usages) as we discussed in the chat?

min-height: 16px;
width: auto;
vertical-align: text-bottom;
}
Expand Down