Bump Certbot and ACME dependencies with new tests added #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedski
force-pushed
the
tedski/chore/testing
branch
2 times, most recently
from
788a182 to
a3a0e43
Compare
Adds testing for the Authenticator that follow the conventions of the upstream certbot repository. This should ensure compatibility if this was ever merged upstream.
- Drops support for EOL Python 3.7 - Bumps Certbot/ACME to 2.11.0 - Adds testing target for Python 3.12
tedski
force-pushed
the
tedski/chore/testing
branch
from
a3a0e43 to
39df441
Compare
|
@stephenjust @dalbothek can you take a look at this and help unblock projects that depend on this library? Thanks! |
|
Thank you very much for your contribution! I might not find time to review your changes in detail until next Tuesday, but I will make sure to get a new version out by then. |
|
Any chance this can get reviewed this week, @dalbothek ? |
|
Thank you for the reminder, the changes have now been merged and a new version 0.7.0 is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outdated dependencies are blocking home-assistant/addons#3751.
This adds some testing to the Authenticator (more to come later). The tests are configured to run via pytest and the GitHub Actions have been updated to run the tests during Compatibility Testing.
This also bumps the Cerbot/ACME dependencies to 2.11.0 to keep up with the current state and unblock home-assistant/addons#3751.
This drops support for Python 3.7 as it is EOL.