Entities merge requests #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo before merge:
|
Merged
maxlath
reviewed
Oct 29, 2024
jum-s
force-pushed
the
entities-merge-requests
branch
from
2af3076 to
56c73f9
Compare
work_picker should be the only one using the mergeEntities refresh mecanism, hence transfering the mecanism to it
and display reporters also for human tasks now, as they are not only autogenerated anymore, server side
as 4 different types can now be displayed relegate task score to an optional separated box, as they will be less important as autogenerated task will be les prioritized
and minor clean up
and remove 'this is fine' message as it should be replaced with a button 'go to dashboard' soon
which was designed to solve hundred of bot generated tasks, but this PR now prioritise small number of user generated tasks. Removing the backlog simplifies the code, but it comes with a trade off: if several users do tasks at the same time, the offset parameter will leave some undone tasks unseen, since getTask request will only return non archived tasks. A way to solve this problem would be to make an additional request before incrementing the offset to, see is it returned the same task, is not, it means someone else solved a task in the meanwhile. But probable YAGNI should let us solves this problems later if problems arise.
a long wanting feature (imo) to allow close inspection of a cover when solving an edition task by extenstion this is also adding the feature to edition modal
to hint that some variable are null
maxlath
force-pushed
the
entities-merge-requests
branch
from
2d8a9ab to
fe57ee5
Compare
maxlath
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows dataadmin to review task with more entities types (namely
serie,edition,publisherandcollection).Most of the work has been to display relevant related entities within the task layout (see
getRelatedEntitiesSections), which has been kept to direct parents and children entities (ie. no work's authors on series' entities, no authors on edition's entities) to keep it simple for the momentThe other part (create tasks according to their
entitiesType) is detailed in the server side PR (inventaire/inventaire#778) since most of the work is done there.