-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker postgres fix #9041
base: master
Are you sure you want to change the base?
Docker postgres fix #9041
Conversation
- Move from alpine 3.19 to alpine 3.21 - Move from postgres13_client to postgres17_client
- Move from postgres:13 to postgres:16 - Move from redis:7.0 to redis:7-alpine
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9041 +/- ##
==========================================
+ Coverage 85.55% 85.63% +0.07%
==========================================
Files 1177 1177
Lines 52041 52041
Branches 2120 2120
==========================================
+ Hits 44523 44563 +40
+ Misses 6984 6928 -56
- Partials 534 550 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Last time we tried to bump it to 15 we ran into dependency issues fast, this has to be tested thoroughly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But as @matmair said we have to test this properly, so that we don't have the same problem as last time (actually not sure what it was the last time).
I believe that the issue is that we cannot force a change in the database image (e.g. However, we can update the inventree image to a newer version of the postgresql-client libs, which are backwards compatible. Nominally we can change the docker-compose file, as anyone who has setup their docker stack has already downloaded and captured that file. What we should do as part of this PR is provide an instruction for how to update from |
We also need to ensure that just switching out the docker-compose does not fry the database completely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I do not understand most changes here
4f578b7
to
02b3b73
Compare
- Debian based (python3.11-bookworm) - Install essential system packages
- Bump postgresql image from 13 to 15 - Store psql data in the dev/psql directory - Install required frontend packages
To deal with the incompatibility between This has the added advantage that now our devcontainer setup can be used to run playwrigiht tests for the frontend "out of the box" - making the development path a lot smoother. This is somewhat of a "regression" as the two docker setups used to be split in a similar fashion. Note: Additionally, the dev container now builds and runs on M MacBooks too |
Update target versions of alpine and postgresql for our docker image.
Notes
alpine:3.20
postgres:16
TODO
postgres:<x>
tag) does not destroy database