-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] Adjusting Company Switcher Per New Design #2330
Open
Civolilah
wants to merge
13
commits into
invoiceninja:develop
Choose a base branch
from
Civolilah:cleanup/1842-company-switcher
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
56fbd27
Adjusting company switcher with new design
Civolilah 6cdb11b
Implemented new design for company switcher
Civolilah ab1e615
Implemented hiding full sidebar
Civolilah c9d5029
Merge branch 'develop' into cleanup/1842-company-switcher
Civolilah f3161c4
Added icons for mini sidebar
Civolilah 4d5c084
Changed border color
Civolilah 0f04cbd
Cleanup
Civolilah 89027df
Merge branch 'develop' into cleanup/1842-company-switcher
Civolilah f0ef346
Adjusted solution
Civolilah 7897c25
Merge branch 'develop' into cleanup/1842-company-switcher
Civolilah 7f2f9c3
Changed position of icons
Civolilah 48dbed3
Increased text size in company avatar
Civolilah 428ea65
Cleanup
Civolilah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/** | ||
* Invoice Ninja (https://invoiceninja.com). | ||
* | ||
* @link https://github.com/invoiceninja/invoiceninja source repository | ||
* | ||
* @copyright Copyright (c) 2022. Invoice Ninja LLC (https://invoiceninja.com) | ||
* | ||
* @license https://www.elastic.co/licensing/elastic-license | ||
*/ | ||
|
||
import { useUpdateCompanyUser } from '$app/pages/settings/user/common/hooks/useUpdateCompanyUser'; | ||
import { cloneDeep, set } from 'lodash'; | ||
import { useHandleCurrentUserChangeProperty } from './useHandleCurrentUserChange'; | ||
import { useInjectUserChanges } from './useInjectUserChanges'; | ||
|
||
export function useHandleCollapseExpandSidebar() { | ||
const userChanges = useInjectUserChanges(); | ||
|
||
const updateCompanyUser = useUpdateCompanyUser(); | ||
const handleUserChange = useHandleCurrentUserChangeProperty(); | ||
|
||
return (value: boolean) => { | ||
handleUserChange('company_user.react_settings.show_mini_sidebar', value); | ||
|
||
if (userChanges) { | ||
const updatedUserChanges = cloneDeep(userChanges); | ||
|
||
set( | ||
updatedUserChanges, | ||
'company_user.react_settings.show_mini_sidebar', | ||
value | ||
); | ||
|
||
updateCompanyUser(updatedUserChanges); | ||
} | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beganovich I don't think this ever worked correctly. David reported that the speed of collapsing/expanding sidebar is really slow - the reason for that is exactly this logic. The changes object is constantly being injected again because this if statement is almost never true.
By default, the changes object used in this if statement is an empty object ({}), it is never null/undefined. So, that part of the condition is always true, while the second part is equal to false only if the overwrite is passed through options. So, instead of comparing types also, we just want to check if the overwrite is set to true.
The overwrite is never passed as a true value, but also I don't think we ever need to overwrite changes over the changes we currently have.
The same thing applies to
useInjectCompanyChange
- the overwrite never passes the check that is false.