Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Redesigning Notification Slider Per Figma Design #2358

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Civolilah
Copy link
Collaborator

@Civolilah Civolilah commented Feb 10, 2025

@beganovich @turbo124 The PR includes redesigning the notification slider according to the Figma design. Screenshot:

Screenshot 2025-02-12 at 19 19 24

Note: We are missing the "just_now" and "yesterday" translation keywords in the files, so please add them there.

Let me know your thoughts.

@Civolilah Civolilah marked this pull request as ready for review February 12, 2025 18:28
@turbo124
Copy link
Member

turbo124 commented Feb 12, 2025

@Civolilah

unsure what is happening here, on both dev/build the notifications show, but if i refresh the page, i get a minified react error

image

https://react.dev/errors/31?invariant=31&args%5B%5D=object%20with%20keys%20%7Btype%2C%20key%2C%20ref%2C%20props%2C%20_owner%7D

this occurs when i click on the notification bell on a page refresh

image

@Civolilah
Copy link
Collaborator Author

@Civolilah

unsure what is happening here, on both dev/build the notifications show, but if i refresh the page, i get a minified react error

image

https://react.dev/errors/31?invariant=31&args%5B%5D=object%20with%20keys%20%7Btype%2C%20key%2C%20ref%2C%20props%2C%20_owner%7D

this occurs when i click on the notification bell on a page refresh

image

@turbo124 Ah okay, I investigated it just now and I believe I found the solution. Please let me know if it is fixed on your end as well.

@turbo124
Copy link
Member

still broken:

he above error occurred in the

component:

at div
at div
at div
at div
at div
at div
at form
at div
at Ke (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2478:12)
at s9 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:1345:22)
at He4 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:3919:22)
at _e4 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:3991:42)
at div
at div
at http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2091:70
at div
at z (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:1934:38)
at http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2355:14
at l6 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2039:73)
at j3 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2082:17)
at N3 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2063:48)
at l6 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2039:73)
at b2 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2329:25)
at We (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:2400:12)
at s9 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:1345:22)
at He4 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:3919:22)
at Fe4 (http://localhost:3000/node_modules/.vite/deps/@headlessui_react.js?v=0f508998:3956:15)
at Slider (http://localhost:3000/src/components/cards/Slider.tsx:34:18)
at Notifications (http://localhost:3000/src/components/Notifications.tsx:56:15)
at div
at div
at div
at div
at div
at Default (http://localhost:3000/src/components/layouts/Default.tsx:62:15)
at Invoice (http://localhost:3000/src/pages/invoices/Invoice.tsx:61:7)
at Suspense
at Fallback (http://localhost:3000/src/components/Fallback.tsx:29:3)
at Guard (http://localhost:3000/src/common/guards/Guard.tsx:61:3)
at RenderedRoute (http://localhost:3000/node_modules/.vite/deps/chunk-XMUNPH5W.js?v=0f508998:3402:5)
at RenderedRoute (http://localhost:3000/node_modules/.vite/deps/chunk-XMUNPH5W.js?v=0f508998:3402:5)
at Outlet (http://localhost:3000/node_modules/.vite/deps/chunk-XMUNPH5W.js?v=0f508998:3787:26)
at Suspense
at Fallback (http://localhost:3000/src/components/Fallback.tsx:29:3)
at PrivateRoute (http://localhost:3000/src/components/PrivateRoute.tsx:33:25)
at RenderedRoute (http://localhost:3000/node_modules/.vite/deps/chunk-XMUNPH5W.js?v=0f508998:3402:5)
at Routes (http://localhost:3000/node_modules/.vite/deps/chunk-XMUNPH5W.js?v=0f508998:3847:5)
at div
at App (http://localhost:3000/src/App.tsx:57:15)
at ScrollToTop (http://localhost:3000/src/components/ScrollToTop.tsx:30:20)
at Router (http://localhost:3000/node_modules/.vite/deps/chunk-XMUNPH5W.js?v=0f508998:3794:15)
at HashRouter (http://localhost:3000/node_modules/.vite/deps/react-router-dom.js?v=0f508998:502:5)
at GoogleOAuthProvider (http://localhost:3000/node_modules/.vite/deps/@react-oauth_google.js?v=0f508998:41:32)
at GoogleOAuth (http://localhost:3000/src/components/GoogleOAuth.tsx:28:3)
at Provider (http://localhost:3000/node_modules/.vite/deps/chunk-XC6E3NSQ.js?v=0f508998:1274:3)
at QueryClientProvider2 (http://localhost:3000/node_modules/.vite/deps/react-query.js?v=0f508998:2654:21)

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries.
overrideMethod @ hook.js:608Understand this errorAI
chunk-CXJOIMMF.js?v=0f508998:19409 Uncaught Error: Objects are not valid as a React child (found: object with keys {type, key, ref, props, _owner, _store}). If you meant to render a collection of children, use an array instead.
at throwOnInvalidObjectType (chunk-CXJOIMMF.js?v=0f508998:11222:17)
at createChild (chunk-CXJOIMMF.js?v=0f508998:11398:15)
at reconcileChildrenArray (chunk-CXJOIMMF.js?v=0f508998:11570:33)
at reconcileChildFibers2 (chunk-CXJOIMMF.js?v=0f508998:11847:24)
at reconcileChildren (chunk-CXJOIMMF.js?v=0f508998:14292:37)
at updateHostComponent (chunk-CXJOIMMF.js?v=0f508998:14802:11)
at beginWork (chunk-CXJOIMMF.js?v=0f508998:15923:22)
at beginWork$1 (chunk-CXJOIMMF.js?v=0f508998:19749:22)
at performUnitOfWork (chunk-CXJOIMMF.js?v=0f508998:19194:20)
at workLoopSync (chunk-CXJOIMMF.js?v=0f508998:19133:13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants