Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log the base directory when searching all sub-paths for wc3 exe #73

Merged
merged 3 commits into from
Dec 31, 2021

Conversation

Cokemonkey11
Copy link
Contributor

In the current version of code, the exception here logs all the paths that wc3libs tries, but it doesn't mention the base path that was requested.

For debugging wurstscript/WurstScript#1034, it seems more valuable to see what base path was provided by consumer. It is no longer useful to log the "paths tested" since we know that part to be working.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #73 (32c79c0) into master (7ece74a) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     40.88%   40.88%   -0.01%     
  Complexity     1718     1718              
============================================
  Files           432      432              
  Lines         21771    21773       +2     
  Branches       1777     1775       -2     
============================================
  Hits           8902     8902              
- Misses        12336    12338       +2     
  Partials        533      533              
Impacted Files Coverage Δ
...oonlightflower/wc3libs/port/NotFoundException.java 33.33% <0.00%> (-16.67%) ⬇️
...lightflower/wc3libs/port/win/WinGameExeFinder.java 22.41% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ece74a...32c79c0. Read the comment docs.

@Cokemonkey11 Cokemonkey11 requested a review from peq November 3, 2021 23:36
Copy link

@peq peq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just the small changes with using Paths.get.

As @Frotty usually maintains this repo, I would let him do the merge then :)

@Frotty Frotty merged commit d363515 into inwc3:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants