Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overall typing and add initial support for Go To Declaration on x-data derived properties #45

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

joao-pedro-braz
Copy link
Contributor

@joao-pedro-braz joao-pedro-braz commented Sep 25, 2023

A couple of improvements:

  • Added typing support for $el and $root
  • Added typing support for events from x-on: and @
  • Improved intellisense for x-data derived properties
  • Added initial support for Go To Declaration for x-data derived properties

@joao-pedro-braz joao-pedro-braz force-pushed the main branch 3 times, most recently from 0a98eb1 to dac514f Compare September 26, 2023 20:35
@joao-pedro-braz joao-pedro-braz changed the title Make $el and $root typed, based on the HTML tags Improve overall typing and add initial support for Go To Declaration on x-data derived properties Sep 26, 2023
Added the following improvements:
- Added typing support for `$el` and `$root`
- Improved intellisense for `x-data` derived properties
- Added initial support for Go To Declaration for `x-data` derived properties
@inxilpro
Copy link
Owner

inxilpro commented Jan 2, 2024

Wow! Somehow I missed this until just now. Looks amazing. I'm going to do a little testing before I merge, but thanks!

@inxilpro inxilpro merged commit 98ba145 into inxilpro:main Jan 2, 2024
2 checks passed
@inxilpro
Copy link
Owner

inxilpro commented Jan 2, 2024

@joao-pedro-braz it looks like createExpressionFromText can fail and trigger an error in the IDE if the expression isn't parsable. I've come up with a short-term solution for Laravel's Blade syntax but this could be a larger issue. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants