Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Chinese Translation #134

Merged
merged 6 commits into from
Dec 22, 2019
Merged

Simplified Chinese Translation #134

merged 6 commits into from
Dec 22, 2019

Conversation

dingyifei
Copy link
Contributor

@dingyifei dingyifei commented Oct 4, 2019

#130
https://en.wikipedia.org/wiki/Template:ISO_639_name

Maybe it should be renamed to zh-s.ini or zhs.ini?

temporarely name it `chi.ini` since `zho.ini` is taken by Traditional Chinese
@Aericio Aericio added Hacktoberfest For the "Hacktoberfest" contributers Translation labels Oct 4, 2019
chi.ini -> zhs.ini (Simplified Chinese)
zho.ini -> zht.ini (Traditional Chinese)
@dingyifei
Copy link
Contributor Author

I renamed zho.ini and chi.ini to zht.ini and zhs.ini

@dingyifei
Copy link
Contributor Author

I see #138 had changed zho.ini, should I revert my 7db2ece commit?

@Aericio
Copy link
Collaborator

Aericio commented Oct 5, 2019

No, since you're first we'll accept yours and reject his.

@inxomnyaa
Copy link
Owner

I guess it doesn't matter that much - it is just a guideline, but the filename is never shown anywhere else than github, neither exposed in the plugin - what matters is the language.name string :P
The iso639-2 format was just so people can easier recognize the files they have to edit, since we had duplicated languages last year with different file names

@@ -1,5 +1,5 @@
; Updated time : 26th 07 2017
language.name = "Chinese"
language.name = "Traditional Chinese"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point to change it 👍

@inxomnyaa inxomnyaa added this to the 10.0.0 milestone Oct 9, 2019
@dingyifei
Copy link
Contributor Author

I revert the cht.ini and chs.ini back to zho.ini and chi.ini based on user4086's comment on that StackExchange question

@@ -1,5 +1,5 @@
; Updated time : 26th 07 2017
language.name = "Traditional Chinese"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't this changed to remove confusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revert the change, then changed zho.ini to "Traditional Chinese".... right now the "zho.ini" should be Traditional Chinese and the "chi.ini" is "Simplified Chinese". I just realized I did the opposite of what the post said...

@dingyifei
Copy link
Contributor Author

I switch the zho.ini and chi.ini, so now Simplified Chinese = "zho.ini" and Traditional Chinese = "chi.ini" as the post said.

I'll bet that the designer takes "zho" to mean simplified Chinese and "chi" to mean traditional Chinese. Reason: "zhong" is a mainland-style "Pinyin" transcription, and in regions where traditional Chinese is used (such as Taiwan and Hong Kong), "Pinyin" is not the default phonetic system. – user4086

@inxomnyaa
Copy link
Owner

Ok cool 👍 😊

@inxomnyaa inxomnyaa merged commit edd6ed3 into inxomnyaa:translations Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest For the "Hacktoberfest" contributers State: In Progress Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants