-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified Chinese Translation #134
Conversation
temporarely name it `chi.ini` since `zho.ini` is taken by Traditional Chinese
chi.ini -> zhs.ini (Simplified Chinese) zho.ini -> zht.ini (Traditional Chinese)
I renamed zho.ini and chi.ini to zht.ini and zhs.ini |
No, since you're first we'll accept yours and reject his. |
I guess it doesn't matter that much - it is just a guideline, but the filename is never shown anywhere else than github, neither exposed in the plugin - what matters is the language.name string :P |
resources/lang/zht.ini
Outdated
@@ -1,5 +1,5 @@ | |||
; Updated time : 26th 07 2017 | |||
language.name = "Chinese" | |||
language.name = "Traditional Chinese" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point to change it 👍
This reverts commit 7db2ece.
I revert the cht.ini and chs.ini back to zho.ini and chi.ini based on user4086's comment on that StackExchange question |
resources/lang/zho.ini
Outdated
@@ -1,5 +1,5 @@ | |||
; Updated time : 26th 07 2017 | |||
language.name = "Traditional Chinese" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't this changed to remove confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I revert the change, then changed zho.ini to "Traditional Chinese".... right now the "zho.ini" should be Traditional Chinese and the "chi.ini" is "Simplified Chinese". I just realized I did the opposite of what the post said...
I switch the zho.ini and chi.ini, so now Simplified Chinese = "zho.ini" and Traditional Chinese = "chi.ini" as the post said.
|
Ok cool 👍 😊 |
#130
https://en.wikipedia.org/wiki/Template:ISO_639_name
Maybe it should be renamed to zh-s.ini or zhs.ini?